Update CHANGELOG for unreleased 15.6 branch#9827
Merged
flarnie merged 2 commits intofacebook:masterfrom Jun 1, 2017
Merged
Conversation
bvaughn
reviewed
Jun 1, 2017
| * Downgrade deprecation warnings to use `console.warn` instead of `console.error`. ([@flarnie](https://github.com/flarnie) in [#9753](https://github.com/facebook/react/pull/9753)) | ||
| * Fix issue where environment variable was not being transformed by browserify. ([@mridgway](https://github.com/mridgway) in [#9642](https://github.com/facebook/react/pull/9642)) | ||
| * Add deprecation warnings and separate module for React.DOM factory helpers. ([@nhunzaker](https://github.com/nhunzaker) in [#8356](https://github.com/facebook/react/pull/8356)) | ||
| * Add deprecation warning for React.createClass helper. ([@nhunzaker](https://github.com/nhunzaker) in [#8356](https://github.com/facebook/react/pull/8356)) |
Contributor
There was a problem hiding this comment.
The deprecation warning added in this PR is about DOM factories rather than createClass. Did you tag the wrong PR? Seems like this meant to go with the line above.
Contributor
Author
There was a problem hiding this comment.
Oh thanks! I didn't mean to add that line at all - since the createClass deprecation warning was noted in the 15.5 changelog we don't need to say it again, do we?
bvaughn
suggested changes
Jun 1, 2017
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
Everything looks good except the one PR link!
flarnie
force-pushed
the
updateChangelogFor15.6RC
branch
from
2c3e384 to
e7bdfdc
Compare
**what is the change?:** Added entries for the latest changes. **why make this change?:** We are about to do an RC release and folks can look at these notes to see what is in the planned release. **test plan:** Visual inspection **issue:** facebook#9398
flarnie
force-pushed
the
updateChangelogFor15.6RC
branch
from
e7bdfdc to
f96f4ca
Compare
**what is the change?:** We decided to strike through the previous changelog item and add it to the more recent changelog section, since this is the release where the deprecation warning will actually go out. **why make this change?:** To make things clear for everyone using 15.6 **test plan:** Visual inspection **issue:** facebook#9398
bvaughn
approved these changes
Jun 1, 2017
Contributor
Contributor
Author
|
@TrySound nice catch! I'll update that now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what is the change?:
Added entries for the latest changes.
why make this change?:
We are about to do an RC release and folks can look at these notes to
see what is in the planned release.
test plan:
Visual inspection
issue:
#9398